-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Pull request template. #304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good. I have a few nitpickings around visual noise, but beyond that we are good to go 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nit and we are good!
Just as a side note, I notice there is some vite stuff in the commits for this PR. If you want to avoid this, you should create new branches from the original remote's main 👍 It will look cleaner and is better practice in general when your intent is to open a PR on the original remote's main. That's not an issue for this PR because I will squash everything into a single commit so we won't see anything, but keep this in mind. |
I have tried to do this in PR #294 #295 #296. But when i crate a new branch from main and push commits somehow the vite commits always stick with them in github. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And we are go for merge 👍 Thank you for your work ^^
Related Tickets
Fixes #ISSUE_NUMBER
Description
Unexpected difficulties
How to test
Follow-up