Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Pull request template. #304

Merged
merged 8 commits into from
Feb 12, 2025
Merged

Conversation

nakul-py
Copy link
Contributor

@nakul-py nakul-py commented Feb 11, 2025

Related Tickets

Fixes #ISSUE_NUMBER

Description

Unexpected difficulties

How to test

Follow-up

Copy link
Owner

@BarthPaleologue BarthPaleologue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good. I have a few nitpickings around visual noise, but beyond that we are good to go 👍

Copy link
Owner

@BarthPaleologue BarthPaleologue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit and we are good!

@BarthPaleologue
Copy link
Owner

Just as a side note, I notice there is some vite stuff in the commits for this PR. If you want to avoid this, you should create new branches from the original remote's main 👍 It will look cleaner and is better practice in general when your intent is to open a PR on the original remote's main.

That's not an issue for this PR because I will squash everything into a single commit so we won't see anything, but keep this in mind.

@nakul-py
Copy link
Contributor Author

Just as a side note, I notice there is some vite stuff in the commits for this PR. If you want to avoid this, you should create new branches from the original remote's main 👍 It will look cleaner and is better practice in general when your intent is to open a PR on the original remote's main.

That's not an issue for this PR because I will squash everything into a single commit so we won't see anything, but keep this in mind.

I have tried to do this in PR #294 #295 #296. But when i crate a new branch from main and push commits somehow the vite commits always stick with them in github.

Copy link
Owner

@BarthPaleologue BarthPaleologue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we are go for merge 👍 Thank you for your work ^^

@BarthPaleologue BarthPaleologue merged commit 1531351 into BarthPaleologue:main Feb 12, 2025
4 checks passed
@nakul-py nakul-py deleted the pr branch February 12, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants